Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/161#discussion_r17531028
--- Diff:
software/base/src/test/java/brooklyn/entity/brooklynnode/BrooklynNodeIntegrationTest.java
---
@@ -427,6 +431,48 @@ public void testHttps() throws Exception {
}
}
+ public void testStopAndKillAppsEffector() throws Exception {
+
createNodeAndExecStopEffector(BrooklynNode.STOP_NODE_AND_KILL_APPS);
+ }
+
+ public void testStopButLeaveAppsEffector() throws Exception {
+
createNodeAndExecStopEffector(BrooklynNode.STOP_NODE_BUT_LEAVE_APPS);
+ }
+
+ private void createNodeAndExecStopEffector(Effector<?> eff) throws
Exception {
--- End diff --
maybe replace lines 464 onwards with a simple `brooklynNode.invoke(eff,
...)`, return the task, and let the calling test inspect the tasks and children
(adding a new `@Test testStopPlainThrowsException` to perform the existing test
on lines 464-467) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
