Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/161#discussion_r17724012
--- Diff:
usage/rest-server/src/main/java/brooklyn/rest/resources/ServerResource.java ---
@@ -58,9 +62,13 @@ public void reloadBrooklynProperties() {
}
@Override
- public void shutdown(final boolean stopAppsFirst, final long
delayMillis) {
+ public void shutdown(final boolean stopAppsFirst, final long
delayMillis, String httpReturnTimeout) {
log.info("REST call to shutdown server,
stopAppsFirst="+stopAppsFirst+", delayMillis="+delayMillis);
-
+
+ Duration httpReturnTimeoutDuration =
Duration.parse(httpReturnTimeout);
--- End diff --
Duration.parse returns null on null input. Null value for httpReturnTimeout
results in no request blocking, to preserve exiting behaviour (but the
behaviour changes in #172).
Empty string will result in parsing error which I think is a good thing.
Better to keep the behaviour identical to TypeCoercions logic. Though a
Preconditions check would be better in this case, I will add the checks to #172.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
