Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/161#discussion_r17724720
--- Diff:
usage/rest-server/src/main/java/brooklyn/rest/resources/ServerResource.java ---
@@ -58,9 +62,13 @@ public void reloadBrooklynProperties() {
}
@Override
- public void shutdown(final boolean stopAppsFirst, final long
delayMillis) {
+ public void shutdown(final boolean stopAppsFirst, final long
delayMillis, String httpReturnTimeout) {
log.info("REST call to shutdown server,
stopAppsFirst="+stopAppsFirst+", delayMillis="+delayMillis);
-
+
+ Duration httpReturnTimeoutDuration =
Duration.parse(httpReturnTimeout);
--- End diff --
Minor point but I'd add a check in this code that explicitly treats blank
as null. That feels safe here to me...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
