Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/194#discussion_r18144356
  
    --- Diff: 
usage/launcher/src/main/java/brooklyn/launcher/BrooklynLauncher.java ---
    @@ -808,6 +826,32 @@ protected void createApps() {
             }
         }
     
    +    protected void startBrooklynNode() {
    +        final String classpath = System.getenv("INITIAL_CLASSPATH");
    +        if (classpath == null || Strings.isBlank(classpath)) {
    +            LOG.warn("Cannot find INITIAL_CLASSPATH environment variable, 
skipping BrooklynNode entity creation");
    +            return;
    +        }
    +        ApplicationBuilder brooklyn = new ApplicationBuilder() {
    +            @Override
    +            protected void doBuild() {
    +                addChild(EntitySpec.create(BrooklynNode.class)
    +                        .configure(SoftwareProcess.ENTITY_STARTED, true)
    +                        .configure(SoftwareProcess.RUN_DIR, 
System.getenv("ROOT"))
    +                        .configure(SoftwareProcess.INSTALL_DIR, 
System.getenv("BROOKLYN_HOME"))
    +                        .configure(BrooklynNode.ENABLED_HTTP_PROTOCOLS, 
ImmutableList.of(webServer.getHttpsEnabled() ? "https" : "http"))
    +                        .configure(webServer.getHttpsEnabled() ? 
BrooklynNode.HTTPS_PORT : BrooklynNode.HTTP_PORT, 
PortRanges.fromInteger(webServer.getActualPort()))
    +                        .configure(BrooklynNode.WEB_CONSOLE_BIND_ADDRESS, 
bindAddress)
    +                        
.configure(BrooklynNode.WEB_CONSOLE_PUBLIC_ADDRESS, publicAddress)
    +                        .configure(BrooklynNode.CLASSPATH, 
Splitter.on(":").splitToList(classpath))
    +                        .displayName("Brooklyn Console"));
    +            }
    +        };
    +        brooklyn.appDisplayName("Brooklyn")
    +                .manage(managementContext)
    +                .start(ImmutableList.of(new LocalhostMachine()));
    --- End diff --
    
    Isn't `new LocalhostMachine()` deprecated? Thought you should use a 
`LocationSpec`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to