Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/248#discussion_r18969362
--- Diff:
usage/launcher/src/main/java/brooklyn/launcher/BrooklynLauncher.java ---
@@ -449,35 +453,65 @@ public BrooklynLauncher haHeartbeatPeriod(Duration
val) {
return this;
}
- public BrooklynMementoRawData retrieveState() {
- initManagementContext();
+ public void copyPersistedState(String destinationDir, String
destinationLocation) {
+ copyPersistedState(destinationDir, destinationLocation, null);
+ }
+ public void copyPersistedState(String destinationDir, String
destinationLocation, CompoundTransformer transformer) {
+ initManagementContext();
try {
+ highAvailabilityMode = HighAvailabilityMode.MASTER;
initPersistence();
} catch (Exception e) {
handleSubsystemStartupError(ignorePersistenceErrors,
"persistence", e);
}
+ ManagementPlaneSyncRecord planeState =
managementContext.getHighAvailabilityManager().getManagementPlaneSyncState();
+ BrooklynMementoRawData memento = retrieveState();
+ BrooklynMementoRawData newMemento = memento;
+ if (transformer != null) {
+ try {
+ newMemento = transformer.transform(memento);
+ } catch (Exception e) {
+ throw Throwables.propagate(e);
+ }
+ }
+ persistState(newMemento, planeState, destinationDir,
destinationLocation);
+
+ }
+
+ /** @deprecated since 0.7.0 use {@link #copyPersistedState} instead */
+ // Make private after deprecation
+ @Deprecated
+ public BrooklynMementoRawData retrieveState() {
+ initManagementContext();
try {
return
managementContext.getRebindManager().retrieveMementoRawData();
-
+
} catch (Exception e) {
Exceptions.propagateIfFatal(e);
- LOG.debug("Error rebinding to persisted state (rethrowing):
"+e, e);
- throw new FatalRuntimeException("Error rebinding to persisted
state: "+
- Exceptions.collapseText(e), e);
+ LOG.debug("Error rebinding to persisted state (rethrowing): "
+ e, e);
+ throw new FatalRuntimeException("Error rebinding to persisted
state: " +
+ Exceptions.collapseText(e), e);
}
}
+ /** @deprecated since 0.7.0 use {@link #copyPersistedState} instead */
+ // Make private after deprecation
+ @Deprecated
public void persistState(BrooklynMementoRawData memento, String
destinationDir, String destinationLocation) {
+ persistState(memento, null, destinationDir, destinationLocation);
+ }
+
+ private void persistState(BrooklynMementoRawData memento,
ManagementPlaneSyncRecord planeRecord,
--- End diff --
call it `copyPersistedState` for consistency and to avoid confusion with
the normal persistence mechanism?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
