Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/248#discussion_r18969715
--- Diff:
core/src/main/java/brooklyn/management/ha/ManagementPlaneSyncRecordPersisterToObjectStore.java
---
@@ -291,6 +291,15 @@ public void waitForWritesCompleted(Duration timeout)
throws InterruptedException
masterWriter.waitForCurrentWrites(timeout);
}
+ public void checkpoint(ManagementPlaneSyncRecord record) {
+ init();
+ for (ManagementNodeSyncRecord node :
record.getManagementNodes().values()) {
+ if (node.getNodeId() != null) {
--- End diff --
that seems reasonable. `id` might not be null in future, maybe better to
filter based on `INITIALIZING` state (or either, i.e. that or `id==null`
triggers exclusion)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
