Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/303#discussion_r19938071
--- Diff: core/src/main/java/brooklyn/config/BrooklynLogging.java ---
@@ -25,4 +30,45 @@
public static final String REST = "brooklyn.REST";
+ /** For convenience here, since SLF4J does not define such an enum */
+ public static enum LoggingLevel { ERROR, WARN, INFO, DEBUG, TRACE }
+
+ /** As methods on {@link Logger} but taking the level as an argument */
+ public static final void log(Logger logger, LoggingLevel level, String
message, Object... args) {
+ switch (level) {
--- End diff --
i think in places like this we *don't* want a default, because we want the
compiler to direct us that the new case needs to be handled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
