Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/303#discussion_r19940751
--- Diff: core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java
---
@@ -1235,7 +1249,20 @@ public void onUnmanaged(BrooklynObject instance) {
}
}
}
+
+ /** logs at debug, except during subsequent read-only rebinds, in
which it logs trace */
+ private void logRebindingDebug(String message, Object... args) {
+ if (shouldLogRebinding()) {
+ LOG.debug(message, args);
+ } else {
+ LOG.trace(message, args);
+ }
+ }
+ protected boolean shouldLogRebinding() {
+ return (readOnlyRebindCount < 5) || (readOnlyRebindCount%1000==0);
--- End diff --
It's duplication, but makes the code more readable. Makes the different
possible states explicit. Even better would be `!readOnlyRunning ||
(readOnlyRebindCount < 5) || (readOnlyRebindCount%1000==0);`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
