Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/305#discussion_r19999247
--- Diff:
software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeImpl.java
---
@@ -85,19 +89,19 @@ public CouchbaseNodeDriver getDriver() {
@Override
public void init() {
super.init();
-
+
subscribe(this, Attributes.SERVICE_UP, new
SensorEventListener<Boolean>() {
@Override
public void onEvent(SensorEvent<Boolean> booleanSensorEvent) {
if (Boolean.TRUE.equals(booleanSensorEvent.getValue())) {
Integer webPort =
getAttribute(CouchbaseNode.COUCHBASE_WEB_ADMIN_PORT);
- Preconditions.checkNotNull(webPort,
CouchbaseNode.COUCHBASE_WEB_ADMIN_PORT+" not set for %s; is an acceptable port
available?", this);
+ Preconditions.checkNotNull(webPort, "Web admin port
not set for %s; is an acceptable port available?", this);
--- End diff --
why this? if you don't like the constant's verbose toString you can do
`.getName()` -- I think that would be better as it says exactly which config
key is relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
