Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/317#discussion_r20188433
--- Diff:
software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeSshDriver.java
---
@@ -256,45 +245,51 @@ public DownloadLinkSegmentComputer(@Nullable
OsDetails os, boolean isV3OrLater,
isRpm = !(osName.contains("deb") || osName.contains("ubuntu"));
is64bit = os.is64bit();
}
- /** separator after the version number used to be _ but is - in
3.0 and later */
+
+ /**
+ * separator after the version number used to be _ but is - in 3.0
and later
+ */
public String getPreVersionSeparator() {
if (!isV3OrLater) return "_";
if (isRpm) return "-";
return "_";
}
+
public String getOsTag() {
// couchbase only provide certain versions; if on other
platforms let's suck-it-and-see
String family;
if (osName.contains("debian")) family = "debian7_";
else if (osName.contains("ubuntu")) family = "ubuntu12.04_";
- else if (osName.contains("centos") || osName.contains("rhel")
|| (osName.contains("red") && osName.contains("hat")))
+ else if (osName.contains("centos") || osName.contains("rhel")
|| (osName.contains("red") && osName.contains("hat")))
--- End diff --
Always use braces...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
