Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/353#discussion_r21027812
--- Diff:
core/src/main/java/brooklyn/location/access/PortForwardManager.java ---
@@ -123,19 +159,90 @@
* Superfluous if {@link #acquirePublicPort(String, Location, int)}
was used,
* but strongly recommended if {@link
#acquirePublicPortExplicit(String, int)} was used
* e.g. if the location is not known ahead of time.
+ *
+ * @deprecated Use {@link #associate(String, HostAndPort, Location,
int)}
*/
+ @Deprecated
public void associate(String publicIpId, int publicPort, Location l,
int privatePort);
- /** Returns the subset of port mappings associated with a given
location. */
- public Collection<PortMapping> getLocationPublicIpIds(Location l);
-
- /** Returns the mapping to a given private port, or null if none. */
- public PortMapping getPortMappingWithPrivateSide(Location l, int
privatePort);
+ /**
+ * Records a public hostname or address to be associated with the
given publicIpId for lookup purposes.
+ * <p>
+ * Conceivably this may have to be access-location specific.
+ *
+ * @deprecated Use {@link #associate(String, HostAndPort, int)} or
{@link #associate(String, HostAndPort, Location, int)}
+ */
+ @Deprecated
+ public void recordPublicIpHostname(String publicIpId, String
hostnameOrPublicIpAddress);
/**
- * Returns true if this implementation is a client which is
immutable/safe for serialization
- * i.e. it delegates to something on an entity or location elsewhere.
+ * Returns a recorded public hostname or address.
+ *
+ * @deprecated Use {@link #lookup(String, int)} or {@link
#lookup(Location, int)}
*/
- public boolean isClient();
+ @Deprecated
+ public String getPublicIpHostname(String publicIpId);
+ /**
+ * Clears a previous call to {@link #recordPublicIpHostname(String,
String)}.
+ *
+ * @deprecated Use {@link #forgetPortMapping(String, int)} or {@link
#forgetPortMapping(Location, int)}
--- End diff --
`forgetPortMapping(Location, int)` doesn't exist.
`forgetPortMapping(Location)` does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
