Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/353#discussion_r21028075
--- Diff:
core/src/main/java/brooklyn/location/access/PortForwardManagerImpl.java ---
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package brooklyn.location.access;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import brooklyn.config.ConfigKey;
+import brooklyn.entity.basic.ConfigKeys;
+import brooklyn.entity.rebind.BasicLocationRebindSupport;
+import brooklyn.entity.rebind.RebindContext;
+import brooklyn.entity.rebind.RebindSupport;
+import brooklyn.location.Location;
+import brooklyn.location.basic.AbstractLocation;
+import brooklyn.mementos.LocationMemento;
+import brooklyn.util.collections.MutableMap;
+
+import com.google.common.annotations.Beta;
+import com.google.common.base.Objects.ToStringHelper;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.Lists;
+import com.google.common.net.HostAndPort;
+
+@SuppressWarnings("serial")
+public class PortForwardManagerImpl extends AbstractLocation implements
PortForwardManager {
+
+ // TODO This implementation is not efficient, and currently has a cap
of about 50000 rules.
+ // Need to improve the efficiency and scale.
+ // A quick win could be to use a different portReserved counter for
each publicIpId,
+ // when calling acquirePublicPort?
+
+ // TODO Callers need to be more careful in acquirePublicPort for which
ports are actually in use.
+ // If multiple apps sharing the same public-ip (e.g. in the same
vcloud-director vOrg) then they
+ // must not allocate the same public port (so can share the same
PortForwardManagerAuthority
+ // via PortForwardManager.Factory.sharedInstance).
+ // However, this still doesn't check if the port is *actually*
available. For example, if a
+ // different Brooklyn instance is also deploying there then we can get
port conflicts, or if
+ // some ports in that range are already in use (e.g. due to earlier
dev/test runs) then this
+ // will not be respected. Callers should probably figure out the port
number themselves, but
+ // that also leads to concurrency issues.
+
+ // TODO The publicIpId means different things to different callers:
+ // - In acquirePublicPort() it is (often?) an identifier of the
actual public ip.
+ // - In later calls to associate(), it is (often?) an identifier for
the target machine
+ // such as the jcloudsMachine.getJcloudsId().
+
+ // TODO Should PortForwardManager be changed to extend
AbstractLocation, or is this wrapper ok?
+
+ private static final Logger log =
LoggerFactory.getLogger(PortForwardManagerImpl.class);
+
+ public static final ConfigKey<String> SCOPE =
ConfigKeys.newStringConfigKey(
--- End diff --
Why redeclare `SCOPE` and `PORT_FORWARD_MANAGER_STARTING_PORT` when they're
already on the interface?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
