[
https://issues.apache.org/jira/browse/BROOKLYN-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228326#comment-14228326
]
ASF GitHub Bot commented on BROOKLYN-92:
----------------------------------------
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21036204
--- Diff:
software/messaging/src/main/java/brooklyn/entity/messaging/activemq/ActiveMQDestinationImpl.java
---
@@ -39,9 +42,11 @@ public ActiveMQDestinationImpl() {
public void onManagementStarting() {
super.onManagementStarting();
- //assume just one BrokerName at this endpoint
+ getBrokerName();
+ Preconditions.checkNotNull(brokerName, "ActiveMQ broker name must
be specified");
--- End diff --
I think it would be better to replace all references to `brokerName` with a
call to `getBrokerName()`.
> Support for customized brokerName for ActiveMQ
> ----------------------------------------------
>
> Key: BROOKLYN-92
> URL: https://issues.apache.org/jira/browse/BROOKLYN-92
> Project: Brooklyn
> Issue Type: Improvement
> Reporter: Hadrian Zbarcea
> Fix For: 0.7.0-M2
>
>
> Mandatory feature for more complex topologies, like networks of brokers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
