[ 
https://issues.apache.org/jira/browse/BROOKLYN-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228333#comment-14228333
 ] 

ASF GitHub Bot commented on BROOKLYN-92:
----------------------------------------

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21036533
  
    --- Diff: 
software/messaging/src/test/java/brooklyn/entity/messaging/activemq/ActiveMQIntegrationTest.java
 ---
    @@ -80,7 +80,7 @@ public void canStartupAndShutdown() throws Exception {
             activeMQ = 
app.createAndManageChild(EntitySpec.create(ActiveMQBroker.class));
     
             activeMQ.start(ImmutableList.of(testLocation));
    -        
EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 
10*60*1000), activeMQ, Startable.SERVICE_UP, true);
    +        
EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 
60*1000), activeMQ, Startable.SERVICE_UP, true);
    --- End diff --
    
    I believe we have these really long time outs because integration tests 
often take much much longer than you would expect when running on low powered 
CI machines (especially when it has low bandwidth and has to download and 
install the program). Although they can be annoying when running locally I 
think it's best we keep them in place.


> Support for customized brokerName for ActiveMQ
> ----------------------------------------------
>
>                 Key: BROOKLYN-92
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-92
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Hadrian Zbarcea
>             Fix For: 0.7.0-M2
>
>
> Mandatory feature for more complex topologies, like networks of brokers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to