[
https://issues.apache.org/jira/browse/BROOKLYN-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228608#comment-14228608
]
ASF GitHub Bot commented on BROOKLYN-92:
----------------------------------------
Github user hzbarcea commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21048237
--- Diff:
software/messaging/src/main/java/brooklyn/entity/messaging/activemq/ActiveMQQueueImpl.java
---
@@ -41,7 +41,7 @@ public String getQueueName() {
}
public void create() {
- if (log.isDebugEnabled()) log.debug("{} adding queue {} to broker
{}", new Object[] {this, getName(), jmxHelper.getAttribute(brokerMBeanName,
"BrokerId")});
--- End diff --
Uhm, let's not. This is extra check is uselss and non-idiomatic for slf4j.
There are quite a bunch of other places in the code that use the same pattern
that should be cleaned up.
> Support for customized brokerName for ActiveMQ
> ----------------------------------------------
>
> Key: BROOKLYN-92
> URL: https://issues.apache.org/jira/browse/BROOKLYN-92
> Project: Brooklyn
> Issue Type: Improvement
> Reporter: Hadrian Zbarcea
> Fix For: 0.7.0-M2
>
>
> Mandatory feature for more complex topologies, like networks of brokers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
