Github user michaeldye commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/471#issuecomment-71680008
  
    @sjcorbett @aledsage Thank you for the discussion. I agree that it really 
should be up to the caller to provide acceptable arguments to 
```Urls.mergePaths(String... items)``` and that this method should merely 
enforce that contract by throwing an exception given a null arg. Since the null 
values in this case aren't dereferenced, but rather passed to 
```StringBuilder.append()```, does an NPE make the most sense? How about an 
```IllegalArgumentException``` and a message including the rest of the path to 
help someone debug it later?
    
    If you agree, I'll update this PR with the behavior desired for mergePaths 
and create another PR with updates to the calling code. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to