Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/538#discussion_r25635499
--- Diff:
core/src/main/java/brooklyn/location/access/PortForwardManagerImpl.java ---
@@ -38,12 +25,25 @@
import brooklyn.location.basic.AbstractLocation;
import brooklyn.mementos.LocationMemento;
import brooklyn.util.collections.MutableMap;
-
import com.google.common.base.Objects.ToStringHelper;
+import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Lists;
import com.google.common.net.HostAndPort;
+import org.slf4j.Logger;
--- End diff --
Try not to let Intellij reorganise the imports. The vast majority of our
code uses the Eclipse defaults for imports, so we should stick to that in
classes that use it.
You can set the formatting in Intellij to use the Eclipse defaults, but I'm
not sure exactly how. Check with @richardcloudsoft ? If you find out, can you
please update
https://brooklyn.incubator.apache.org/v/latest/dev/env/ide/index.html
But I won't let that block merging of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
