Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/538#discussion_r25694968
--- Diff:
core/src/main/java/brooklyn/location/access/PortForwardManager.java ---
@@ -92,6 +144,16 @@
* subsequently be looked up using {@link #lookup(String, int)}.
*/
public void associate(String publicIpId, HostAndPort publicEndpoint,
int privatePort);
+
+ /**
+ * Registers a listener, which will be notified each time a new port
mapping is associated. See {@link #associate(String, HostAndPort, int)}
+ * and {@link #associate(String, HostAndPort, Location, int)}.
+ */
+ @Beta
+ public void addAssociationListener(AssociationListener listener,
Predicate<? super AssociationMetadata> filter);
--- End diff --
Could do with a unit test in PortForwardManagerTest, that the
`onAssociationCreated` and `onAssociationDeleted` methods get called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
