Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/488#discussion_r26125124
--- Diff:
software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseClusterImpl.java
---
@@ -229,8 +229,13 @@ protected void doStart() {
}
((CouchbaseNode)getPrimaryNode()).rebalance();
- } else if (getQuorumSize()>1) {
- log.warn(this+" is not quorate; will likely fail later,
but proceeding for now");
+ } else {
+ if (getQuorumSize()>1) {
--- End diff --
it's long-winded but i think logic is correct. we've established there are
`upNodes` aka `serversToAdd`, and if we are in this `else` block then also
either we're not quorate or we are only adding a single server. in the latter
case we might be quorate hence this check before warning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
