Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/595#discussion_r28531127
  
    --- Diff: core/src/main/java/brooklyn/enricher/basic/Transformer.java ---
    @@ -102,13 +95,65 @@ public void setEntity(EntityLocal entity) {
             }
         }
     
    +    /** returns a function for transformation, for immediate use only (not 
for caching, as it may change) */
    +    @SuppressWarnings("unchecked")
    +    protected Function<SensorEvent<T>, U> getTransformation() {
    --- End diff --
    
    Why might the result of `getTransformation()` change from one call to the 
other? Is it not based on the config values? If so and if we're catering for 
config values changing, then we could override `doReconfigureConfig(...)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to