Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/595#discussion_r28545581
  
    --- Diff: 
docs/guide/yaml/example_yaml/test-app-with-enrichers-slightly-simpler.yaml ---
    @@ -0,0 +1,57 @@
    +#
    +# example showing how enrichers can be set 
    --- End diff --
    
    I'd prefer a file name that is more descriptive (particularly for when 
someone is deciding what yaml to look at). It's unclear from the name whether 
this is simpler use-cases of enrichers or simple yaml format for achieving the 
same thing with enrichers.
    
    Assuming the latter, if there are old files with the old way, I'd prefer us 
to rename those yaml files to "legacy" or some such. If there aren't old files, 
then why call this "slightly-simpler"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to