Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30577981
--- Diff:
core/src/main/java/brooklyn/management/internal/AbstractManagementContext.java
---
@@ -443,6 +441,22 @@ public void setManagementNodeUri(URI uri) {
return uri;
}
+ @Override
+ public CatalogInitialization getCatalogInitialization() {
+ if (catalogInitialization!=null) return catalogInitialization;
--- End diff --
Double-checked locking is broken in Java, unless you declare the variable
volatile
(http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html).
This code is not performance sensitive, so just delete this line to keep
the code simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
