Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30584097
--- Diff: core/src/test/java/brooklyn/catalog/internal/CatalogScanTest.java
---
@@ -161,13 +162,13 @@ public void testMoreTypesThanAnnotationsForApps() {
@Test
public void testAnnotationIsDefault() {
- loadAnnotationsOnlyCatalog();
loadTheDefaultCatalog();
+ int numInDefault =
Iterables.size(defaultCatalog.getCatalogItems(Predicates.alwaysTrue()));
+ loadAnnotationsOnlyCatalog();
int numFromAnnots =
Iterables.size(annotsCatalog.getCatalogItems(Predicates.alwaysTrue()));
- int numInDefault =
Iterables.size(defaultCatalog.getCatalogItems(Predicates.alwaysTrue()));
- Assert.assertEquals(numFromAnnots, numInDefault);
+ Assert.assertEquals(numInDefault, numFromAnnots);
--- End diff --
Could also assert that `> 0`; otherwise could be a bug and a coincidence
that both are zero?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
