Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30586458
--- Diff: usage/cli/src/main/java/brooklyn/cli/Main.java ---
@@ -536,9 +570,10 @@ protected BrooklynLauncher createLauncher() {
BrooklynLauncher launcher;
launcher = BrooklynLauncher.newInstance();
launcher.localBrooklynPropertiesFile(localBrooklynProperties)
- .ignorePersistenceErrors(ignorePersistenceErrors)
- .ignoreWebErrors(ignoreWebErrors)
- .ignoreAppErrors(ignoreAppErrors)
+
.ignorePersistenceErrors(!startupFailOnPersistenceErrors)
--- End diff --
Should we (in separate PR?) align the method names in launcher with the cli
names? e.g. `failOnPersistenceErrors(boolean)`, and deprecate the
`ignorePersistenceErrors(boolean)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
