Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30658508
--- Diff: utils/common/src/main/java/brooklyn/util/javalang/Threads.java ---
@@ -44,7 +46,15 @@ public static boolean removeShutdownHook(Thread hook) {
return Runtime.getRuntime().removeShutdownHook(hook);
} catch (IllegalStateException e) {
// probably shutdown in progress
- log.debug("cannot remove shutdown hook "+hook+": "+e);
+ String text = Exceptions.collapseText(e);
+ if (text.contains("Shutdown in progress")) {
+ if (log.isTraceEnabled()) {
+ log.trace("Could not remove shutdown hook "+hook+":
"+text);
--- End diff --
Normally I'd agree but this is a known exception which is noise in the
logs, only arising from one place. And it appears at the very end of the log
and so is very visible, giving the wrong impression if it looks like a real
problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
