Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/617#discussion_r30659071
  
    --- Diff: usage/cli/src/main/java/brooklyn/cli/lister/ItemDescriptors.java 
---
    @@ -58,8 +65,17 @@
             List<Map<String, Object>> itemDescriptors = Lists.newArrayList();
             
             for (Class<? extends BrooklynObject> type : types) {
    -            Map<String, Object> itemDescriptor = toItemDescriptor(type, 
headingsOnly);
    -            itemDescriptors.add(itemDescriptor);
    +            try {
    +                Map<String, Object> itemDescriptor = 
toItemDescriptor(type, headingsOnly);
    +                itemDescriptors.add(itemDescriptor);
    +            } catch (Throwable throwable) {
    +                if (throwable instanceof InterruptedException)
    --- End diff --
    
    you can get various `*Class*Error` instances here which we don't want to 
treat as fatal.
    probably we should revisit `propagateIfFatal` not to crash and burn on 
arbitrary `Error` instances.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to