Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30709010
--- Diff:
software/base/src/main/java/brooklyn/entity/basic/AbstractSoftwareProcessDriver.java
---
@@ -251,6 +264,183 @@ public InputStream getResource(String url) {
return resource.getResourceFromUrl(url);
}
+ /**
+ * Files and templates to be copied to the server <em>before</em>
pre-install. This allows the {@link #preInstall()}
+ * process to have access to all required resources.
+ * <p>
+ * Will be prefixed with the entity's {@link #getInstallDir() install
directory} if relative.
+ *
+ * @see SoftwareProcess#PRE_INSTALL_FILES
+ * @see SoftwareProcess#PRE_INSTALL_TEMPLATES
+ * @see #copyRuntimeResources()
+ */
+ public void copyPreInstallResources() {
--- End diff --
I presume these were copied unmodified from
AbstractSoftwareProcessSshDriver? Therefore not reviewing thoroughly. If
anything (beyond calling abstract methods at the appropriate points) has
changed, then let me know and I'll review more thoroughly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
