Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/650#discussion_r30709588
--- Diff:
software/base/src/main/java/brooklyn/entity/basic/AbstractSoftwareProcessWinRmDriver.java
---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package brooklyn.entity.basic;
+
+import java.io.File;
+import java.io.InputStream;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.Callable;
+import java.util.concurrent.TimeUnit;
+
+import org.python.core.PyException;
+
+import brooklyn.config.ConfigKey;
+import brooklyn.event.AttributeSensor;
+import brooklyn.event.basic.Sensors;
+import brooklyn.location.basic.WinRmMachineLocation;
+import brooklyn.util.exceptions.ReferenceWithError;
+import brooklyn.util.repeat.Repeater;
+import brooklyn.util.time.Duration;
+import io.cloudsoft.winrm4j.winrm.WinRmToolResponse;
+
+import com.google.api.client.util.Strings;
+import com.google.common.collect.ImmutableList;
+
+public abstract class AbstractSoftwareProcessWinRmDriver extends
AbstractSoftwareProcessDriver {
+
+ AttributeSensor<String> WINDOWS_USERNAME =
Sensors.newStringSensor("windows.username",
+ "Default Windows username to be used when connecting to the
Entity's VM");
+ AttributeSensor<String> WINDOWS_PASSWORD =
Sensors.newStringSensor("windows.password",
+ "Default Windows password to be used when connecting to the
Entity's VM");
+
+ public AbstractSoftwareProcessWinRmDriver(EntityLocal entity,
WinRmMachineLocation location) {
+ super(entity, location);
+ entity.setAttribute(WINDOWS_USERNAME,
location.config().get(WinRmMachineLocation.WINDOWS_USERNAME));
+ entity.setAttribute(WINDOWS_PASSWORD,
location.config().get(WinRmMachineLocation.WINDOWS_PASSWORD));
+ }
+
+ @Override
+ public void runPreInstallCommand(String command) {
+ execute(ImmutableList.of(command));
+ }
+
+ @Override
+ public void setup() {
+ // Default to no-op
+ }
+
+ @Override
+ public void runPostInstallCommand(String command) {
+ execute(ImmutableList.of(command));
+ }
+
+ @Override
+ public void runPreLaunchCommand(String command) {
+ execute(ImmutableList.of(command));
+ }
+
+ @Override
+ public void runPostLaunchCommand(String command) {
+ execute(ImmutableList.of(command));
+ }
+
+ @Override
+ public WinRmMachineLocation getLocation() {
+ return (WinRmMachineLocation)super.getLocation();
+ }
+
+ @Override
+ public String getRunDir() {
+ // TODO: This needs to be tidied, and read from the appropriate
flags (if set)
+ return "$HOME\\brooklyn-managed-processes\\apps\\" +
entity.getApplicationId() + "\\entities\\" +
getEntityVersionLabel()+"_"+entity.getId();
+ }
+
+ @Override
+ public String getInstallDir() {
+ // TODO: This needs to be tidied, and read from the appropriate
flags (if set)
+ return "$HOME\\brooklyn-managed-processes\\installs\\" +
entity.getApplicationId() + "\\" + getEntityVersionLabel()+"_"+entity.getId();
+ }
+
+ @Override
+ public int copyResource(Map<Object, Object> sshFlags, String source,
String target, boolean createParentDir) {
+ if (createParentDir) {
+ createDirectory(getDirectory(target), "Creating resource
directory");
+ }
+ return copyTo(new File(source), new File(target));
+ }
+
+ @Override
+ public int copyResource(Map<Object, Object> sshFlags, InputStream
source, String target, boolean createParentDir) {
+ if (createParentDir) {
+ createDirectory(getDirectory(target), "Creating resource
directory");
+ }
+ return copyTo(source, new File(target));
+ }
+
+ @Override
+ protected void createDirectory(String directoryName, String
summaryForLogging) {
+ getLocation().executePsScript("New-Item -path \"" + directoryName
+ "\" -type directory -ErrorAction SilentlyContinue");
+ }
+
+ protected WinRmToolResponse executeCommand(ConfigKey<String>
regularCommandKey, ConfigKey<String> powershellCommandKey, boolean allowNoOp) {
+ String regularCommand = getEntity().getConfig(regularCommandKey);
+ String powershellCommand =
getEntity().getConfig(powershellCommandKey);
+ if (Strings.isNullOrEmpty(regularCommand) &&
Strings.isNullOrEmpty(powershellCommand)) {
+ if (allowNoOp) {
+ return new WinRmToolResponse("", "", 0);
+ } else {
+ throw new IllegalStateException(String.format("Exactly one
of %s or %s must be set", regularCommandKey.getName(),
powershellCommandKey.getName()));
+ }
+ } else if (!Strings.isNullOrEmpty(regularCommand) &&
!Strings.isNullOrEmpty(powershellCommand)) {
+ throw new IllegalStateException(String.format("%s and %s
cannot both be set", regularCommandKey.getName(),
powershellCommandKey.getName()));
+ }
+
+ if (Strings.isNullOrEmpty(regularCommand)) {
+ return
getLocation().executePsScript(ImmutableList.of(powershellCommand));
+ } else {
+ return
getLocation().executeScript(ImmutableList.of(regularCommand));
+ }
+ }
+
+ public int execute(List<String> script) {
+ return getLocation().executeScript(script).getStatusCode();
+ }
+
+ public int executePowerShellNoRetry(List<String> psScript) {
+ return
getLocation().executePsScriptNoRetry(psScript).getStatusCode();
+ }
+
+ public int executePowerShell(List<String> psScript) {
+ return getLocation().executePsScript(psScript).getStatusCode();
+ }
+
+ public int copyTo(File source, File destination) {
--- End diff --
As commented in WinRmMachineLocation.java, not sure should use `File
destination`, rather than `String destination`, because the OS of the brooklyn
server and target VM may well be different. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
