Github user nakomis commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/717#discussion_r33251476
--- Diff:
software/base/src/main/java/brooklyn/entity/basic/SoftwareProcessImpl.java ---
@@ -449,11 +449,14 @@ protected final void callStartHooks() {}
configKeys.addAll(getEntityType().getConfigKeys());
for (ConfigKey<?> k: configKeys) {
+ Object value = getConfig(k);
if (PortRange.class.isAssignableFrom(k.getType())) {
PortRange p = (PortRange)getConfig(k);
if (p != null && !p.isEmpty())
ports.add(p.iterator().next());
+ } else if (value != null &&
PortRange.class.isAssignableFrom(value.getClass())) {
--- End diff --
Thinking about it, I'm not sure that the first if condition is needed at
all. If the key's type is assignable to PortRange, then the value must be too
(or null)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
