Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/717#issuecomment-115639792
I agree that the changes are useful, probably didn't explain clearly what I
mean in the previous comment.
The current implementation will not resolve the value even if we know that
it is a port range (from the config key type). Something in the spirit of your
initial commit will keep existing behaviour, while still getting us the benefit
from your changes:
```
if config key type is port range {
getConfig(k) - resolve value, we know it's a port range
} else if config key contains ".port" {
getConfig(k) - resolve value
} else {
v = getConfigRaw(k) - doesn't resolve
if (v instanceof PortRange) {
}
}
```
Not important for this PR, but in future we could go one step further and
try to resolve the value with a 0 or a very short timeout so even more cases
are covered.
wdyt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
