GitHub user bostko opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/866

    Winrm commands stdin, stdout, stderr; Commands Live tests

    This PR provides stdin, stderr and stdout support to the Windows commands.
    Look the commits to see the changes
    
    @nakomis Can you please review this?
    
    It has a Live tests for it and there is an example blueprint for windows 
byon location which I can remove from the PR if you'd like.
    
    I also changed the config key ByonLocationResolver.OS_FAMILY. Here are my 
comments on these 
    So JcloudsLocationConfig.OS_FAMILY config key is osFamily and for 
ByonLocationResolver.OS_FAMILY it is osfamily without capital F
    I was thinking for fixing it by moving this config key to AbstractLocation. 
Is it possible that we don't want to include this config to all descendants of 
AbstractLocation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bostko/incubator-brooklyn winrm_std

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #866
    
----
commit 48fef8a18aff07ae8caeea2d8a89493da32bdbba
Author: Valentin Aitken <[email protected]>
Date:   2015-08-19T21:05:23Z

    Add stdOut and stdErr to WinRmDriver

commit 348a8f74695faa743458b65f1b47e5fa8ee9758a
Author: Valentin Aitken <[email protected]>
Date:   2015-08-20T12:41:47Z

    findTaskOrSubTask lower the logging level to debug

commit db7a63e52151f9eb689903edcbc97d89f4e518a0
Author: Valentin Aitken <[email protected]>
Date:   2015-08-20T21:33:44Z

    Commit not working VanillaSoftwareProcessWinrmStreamsLiveTest

commit b6836d1cb011fc9f999e17c3e02ef1b31c563503
Author: Valentin Aitken <[email protected]>
Date:   2015-08-21T16:18:20Z

    Rename ByonLocation's attribute osfamily to osFamily

commit 2ae58dd27502de053cf0d6fe50703909f9522a5c
Author: Valentin Aitken <[email protected]>
Date:   2015-08-24T14:24:13Z

    Added Windows process streams test
    
    - refactored streams tests

commit f748bec7d182d9bea6fd71cc04ab712140cd954c
Author: Valentin Aitken <[email protected]>
Date:   2015-08-25T12:10:05Z

    Power Shell Commands test
    
    - refactored runPreInstallCommand
    - fix imports

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to