Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/866#discussion_r37964775
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessDriver.java
---
@@ -116,11 +116,9 @@ public void start() {
preInstall();
}});
- if
(Strings.isNonBlank(entity.getConfig(BrooklynConfigKeys.PRE_INSTALL_COMMAND))) {
- DynamicTasks.queue("pre-install-command", new Runnable() {
public void run() {
-
runPreInstallCommand(entity.getConfig(BrooklynConfigKeys.PRE_INSTALL_COMMAND));
- }});
- };
+ DynamicTasks.queue("pre-install-command", new Runnable() {
public void run() {
--- End diff --
Seems wrong to have "pre-install-command" as a special case. There is still
a check that the command is non-blank for `POST_INSTALL_COMMAND`,
`PRE_LAUNCH_COMMAND` and `POST_LAUNCH_COMMAND`. We should either include the if
check for all of them or for none of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
