Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/866#discussion_r38082968
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java
---
@@ -72,8 +72,12 @@ public void launch() {
@Override
public boolean isRunning() {
- return executeCommand(VanillaWindowsProcess.CHECK_RUNNING_COMMAND,
- VanillaWindowsProcess.CHECK_RUNNING_POWERSHELL_COMMAND,
false).getStatusCode() == 0;
+ WinRmToolResponse runningCheck =
executeCommand(VanillaWindowsProcess.CHECK_RUNNING_COMMAND,
+ VanillaWindowsProcess.CHECK_RUNNING_POWERSHELL_COMMAND,
false);
+ if(runningCheck.getStatusCode() != 0) {
+ LOG.info(this + " isRunning check failed: exit code " +
runningCheck.getStatusCode() + "; " + runningCheck.getStdErr());
--- End diff --
Instead of logging `this`, I'd log the `getEntity()` (the toString on the
driver might not be good).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
