Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/866#discussion_r37966943
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessStreamsIntegrationTest.java
---
@@ -59,8 +39,24 @@ public void setUp() throws Exception {
}
@Test(groups = "Integration")
+ @Override
public void testGetsStreams() {
- Map<String, String> cmds = ImmutableMap.<String, String>builder()
+ VanillaSoftwareProcess entity =
app.createAndManageChild(EntitySpec.create(VanillaSoftwareProcess.class)
+ .configure(VanillaSoftwareProcess.PRE_INSTALL_COMMAND,
"echo " + getCommands().get("pre-install-command"))
+ .configure(VanillaSoftwareProcess.INSTALL_COMMAND, "echo "
+ getCommands().get("ssh: installing.*"))
+ .configure(VanillaSoftwareProcess.POST_INSTALL_COMMAND,
"echo " + getCommands().get("post-install-command"))
+ .configure(VanillaSoftwareProcess.CUSTOMIZE_COMMAND, "echo
" + getCommands().get("ssh: customizing.*"))
+ .configure(VanillaSoftwareProcess.PRE_LAUNCH_COMMAND,
"echo " + getCommands().get("pre-launch-command"))
+ .configure(VanillaSoftwareProcess.LAUNCH_COMMAND, "echo "
+ getCommands().get("ssh: launching.*"))
+ .configure(VanillaSoftwareProcess.POST_LAUNCH_COMMAND,
"echo " + getCommands().get("post-launch-command"))
+ .configure(VanillaSoftwareProcess.CHECK_RUNNING_COMMAND,
"echo true"));
+ app.start(ImmutableList.of(localhost));
+ assertStreams(entity);
--- End diff --
I'd pass the `cmds` as an argument of `assertStreams(...)`. That slightly
decreases the coupling between the various methods. (very minor point).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
