Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-150919995
All good! Only minor comments.
What I strongly feel should be removed is the `PublicSelfType` and
`PrivateSelfType` generic types, unless there's a good technical reason for
them to stay. Better to have casts, overrides at several fixed points
(`BrooklynObject` and its inheriting interfaces) rather than at each usage
point.
I see a relation as a named symbol, rather than a named item with
behaviour. They are much closer to config keys/sensors, specific to the entity
pairs they are used with. That's why a global namespace (the catalog) is a bit
unexpected, care to explain some more how do you see it used (probably yaml
usage is the main driver for this)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
