Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43106895
--- Diff:
api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/mementos/Memento.java ---
@@ -77,7 +79,8 @@
public Collection<Object> getTags();
+ Map<String, Set<BrooklynObject>> getRelations();
--- End diff --
Agree, string is better for consistency right now. It means we need
untyped `lookup(...)` methods during rebind, which I've added (simply pass
`null` as type constraint argument).
Using `BrooklynObject` is perhaps nicer if we do that everywhere (and clean
up refs to `entityProxy` instead of `entity` etc in the generated XML); however
if we switch to a yaml representation here which I'd like to eventually then
it's a moot point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
