Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44650500
--- Diff:
core/src/test/java/org/apache/brooklyn/core/catalog/internal/SpecParameterInMetaTest.java
---
@@ -43,18 +49,40 @@
public class SpecParameterInMetaTest {
private ManagementContext mgmt;
private BrooklynCatalog catalog;
- private String spec;
+ private String specId;
@BeforeMethod(alwaysRun=true)
public void setUp() {
mgmt = LocalManagementContextForTests.newInstanceWithOsgi();
catalog = mgmt.getCatalog();
- spec =
TestToSpecTransformer.registerSpec(EntitySpec.create(BasicEntity.class));
+ StaticTypePlanTransformer.forceInstall();
+ PlanToSpecFactory.forceAvailable(TestToSpecTransformer.class,
JavaCatalogToSpecTransformer.class);
--- End diff --
Part of the tests depend on StaticTypePlanTransformer, other part on
PlanToSpecFactory, but not at the same time? If so it would be nice to split
them in separate files so the dependencies are clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
