Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44654399
--- Diff:
usage/camp/src/main/java/org/apache/brooklyn/camp/brooklyn/api/AssemblyTemplateSpecInstantiator.java
---
@@ -23,19 +23,23 @@
import org.apache.brooklyn.api.entity.Application;
import org.apache.brooklyn.api.entity.EntitySpec;
+import
org.apache.brooklyn.api.mgmt.classloading.BrooklynClassLoadingContext;
import org.apache.brooklyn.camp.CampPlatform;
import org.apache.brooklyn.camp.spi.AssemblyTemplate;
import
org.apache.brooklyn.camp.spi.instantiate.AssemblyTemplateInstantiator;
-import
org.apache.brooklyn.core.mgmt.classloading.BrooklynClassLoadingContext;
public interface AssemblyTemplateSpecInstantiator extends
AssemblyTemplateInstantiator {
+ @Deprecated /** @deprecaed since 0.9.0 include encountered types */
+ EntitySpec<? extends Application>
createApplicationSpec(AssemblyTemplate template, CampPlatform platform,
BrooklynClassLoadingContext loader);
+
/**
* Gets the single item returned by {@link #createServiceSpecs}
* and wraps it in an Application if needed, applying top-level
* attributes and locations to the root entity.
*/
- EntitySpec<? extends Application>
createApplicationSpec(AssemblyTemplate template, CampPlatform platform,
BrooklynClassLoadingContext loader);
+ EntitySpec<? extends Application>
createApplicationSpec(AssemblyTemplate template, CampPlatform platform,
BrooklynClassLoadingContext loader, Set<String> encounteredCatalogTypes);
--- End diff --
Doesn't look right, aren't application specs always top level?
On another note, I haven't removed this method just for backwards
compatibility. It belongs to an utils class with the `createServiceSpecs` doing
the heavy lifting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
