jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r266727251
########## File path: src/brpc/mysql_command.cpp ########## @@ -0,0 +1,43 @@ +// Copyright (c) 2015 Baidu, Inc. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Authors: Ge,Jun ([email protected]) + +#include "brpc/mysql_command.h" +#include "butil/sys_byteorder.h" +#include "butil/logging.h" // LOG() +#include <ios> + +namespace brpc { + +butil::Status MysqlMakeCommand(butil::IOBuf* outbuf, + const MysqlCommandType type, + const std::string& stmt, + const uint8_t seq) { + if (outbuf == NULL || stmt.length() == 0) { + return butil::Status(EINVAL, "Param[outbuf] or [stmt] is NULL"); + } + outbuf->clear(); + butil::IOBuf payload; + payload.push_back(type); + payload.append(stmt); Review comment: 这个payload没有太大必要。 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
