jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267205848
########## File path: src/brpc/mysql_command.cpp ########## @@ -0,0 +1,45 @@ +// Copyright (c) 2015 Baidu, Inc. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Authors: Ge,Jun ([email protected]) + +#include "brpc/mysql_command.h" +#include "butil/sys_byteorder.h" +#include "butil/logging.h" // LOG() + +namespace { +const uint32_t max_package_size = 0xFFFFFF; +}; +namespace brpc { +butil::Status MysqlMakeCommand(butil::IOBuf* outbuf, Review comment: 建议不要clear outbuf并改名AppendMySQLCommand，在外部clear更加灵活。 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
