zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r270268975
########## File path: src/brpc/details/health_check.cpp ########## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Authors: Ge,Jun (ge...@baidu.com) +// Jiashun Zhu(zhujias...@baidu.com) + +#include "brpc/details/health_check.h" +#include "brpc/socket.h" +#include "brpc/channel.h" +#include "brpc/controller.h" +#include "brpc/details/controller_private_accessor.h" +#include "brpc/global.h" +#include "brpc/log.h" +#include "bthread/unstable.h" +#include "bthread/bthread.h" + +namespace brpc { + +// declared at socket.cpp +extern SocketVarsCollector* g_vars; + +DEFINE_string(health_check_path, "", "Http path of health check call." + "By default health check succeeds if the server is connectable." + "If this flag is set, health check is not completed until a http " + "call to the path succeeds within -health_check_timeout_ms(to make " + "sure the server functions well)."); +DEFINE_int32(health_check_timeout_ms, 500, "The timeout for both establishing " + "the connection and the http call to -health_check_path over the connection"); + +class HealthCheckChannel : public brpc::Channel { +public: + HealthCheckChannel() {} + ~HealthCheckChannel() {} + + int Init(SocketId id, const ChannelOptions* options); +}; + +int HealthCheckChannel::Init(SocketId id, const ChannelOptions* options) { + brpc::GlobalInitializeOrDie(); + if (InitChannelOptions(options) != 0) { + return -1; + } + _server_id = id; + return 0; +} + +class OnAppHealthCheckDone : public google::protobuf::Closure { Review comment: 这个当时讨论过，用AppCheck的原因是Http只是实现方式。目前client打开这个功能的话，需要由用户来保证这个接口server是支持的 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
