zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268420430
##########
File path: src/brpc/socket.cpp
##########
@@ -1026,6 +1125,9 @@ bool HealthCheckTask::OnTriggeringTask(timespec*
next_abstime) {
}
ptr->Revive();
ptr->_hc_count = 0;
+ if (ptr->IsHealthCheckingUsingRPC()) {
Review comment:
不在revive函数中直接StartCheck的原因是Revive就应该做好自己的事情，让StartCheck交给更上层控制逻辑做。从这个角度来说，Revive这个函数是不应该动的，用该把_health_checking_using_rpc的赋值放到WaitAndReset中更合适。上面提到的熔断的Reset可能也应该放到WaitAndReset中
@TousakaRin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
