I have checked other three apache projects and the comment style they use is /* */ . Should we use the same style to get consistency?
other project file: https://github.com/apache/spark/blob/974f52499271848705c9eb209373f27d808fb72b/sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala https://github.com/apache/hbase/blob/master/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/Constants.java https://github.com/apache/incubator-dubbo/blob/5298afdf401185876edd49b0ad5755f8f618e4cb/dubbo-common/src/test/java/org/apache/dubbo/common/beanutil/JavaBeanAccessorTest.java Wang,Weibing <[email protected]> 于2019年4月10日周三 下午3:56写道： > Hi, all > I'd like you to review this license header. If it has no problem, I will > add the header to all source files and replace the exist one. > > // Licensed to the Apache Software Foundation (ASF) under one > // or more contributor license agreements. See the NOTICE file > // distributed with this work for additional information > // regarding copyright ownership. The ASF licenses this file > // to you under the Apache License, Version 2.0 (the > // "License"); you may not use this file except in compliance > // with the License. You may obtain a copy of the License at > // > // http://www.apache.org/licenses/LICENSE-2.0 > // > // Unless required by applicable law or agreed to in writing, > // software distributed under the License is distributed on an > // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > // KIND, either express or implied. See the License for the > // specific language governing permissions and limitations > // under the License. > > > > 在 2019/4/9 08:46，“tan zhongyi”<[email protected]> 写入: > > OK, let me push us to work on our tasks. > > > 在 2019/3/29 下午4:07，“tan zhongyi”<[email protected]> 写入: > > Great，thanks huwenwei. > > Now Let me to clarify the task of our first release > > 1. Get all dependency third party’s copyright and apppend them to > brpc License file > @ Zhangyi Chen > Hi, zhangyi，this task is the most difficult work for this release > You need to add every needed third party copyright into our's LICENSE > file. > If you have any problem, please let us know, we will help on that > > 2. Add Notice and Disclaimer file to mention its copyright belong > to apache foundation > @tanzhongyi already checked in, marked as done > > 3. Make a short license header, and add the header to all source > files, including .h, .cpp, .java, etc > @wang weibing > Hi, weibing, would you please make a short license header for us to > review first? > thanks > > 4. Check the source tarball to make sure it does not contain > binary files except for data > @TanZhongyi pending > > 5. Prepare release note to list all import checkin and features > @James Ge ? > Hi, james, any progress? > > > 6. Update Readme to add one section as “How to build” > @ huwenwei > Hi, huwenwei, any progress? > > > We can start to work now, and discuss related issues in this mail > list to keep a good record. > Thanks > > The most difficult part is #1, we need to list all third party > code into brpc's License file, > If not permitted, we need to find another solution. > > > > 在 2019/3/29 下午2:41，“Hu,Wenwei”<[email protected]> 写入: > > I would like take 6. > > > > 在 2019/3/28 09:23，“tan zhongyi”<[email protected]> 写入: > > Thanks，zhangyi， > > Anyone else who want to volunteer to take some task？ > > 在 2019/3/27 下午10:17，“Zhangyi Chen”<[email protected]> > 写入: > > I would like take 1 and 2. > > On Tue, Mar 26, 2019 at 2:25 PM tan zhongyi < > [email protected]> wrote: > > > Hi， all， > > > > We need to assign task for our first release . > > Anyone who volunteer to take ? > > Here is the task list, you can reply with it with > your interested task, > > Thanks > > > > > > Here is the task list： > > 1. Get all dependency third > party’s copyright and > > apppend them to brpc License file > > > > 2. Add Notice and Disclaimer file to > mention its copyright > > belong to apache foundation > > > > 3. Make a short license header, and add > the header to all > > source files, including .h, .cpp, .java, etc > > > > 4. Check the source tarball to make sure > it does not contain > > binary files except for data > > > > 5. Prepare release note to list all > import checkin and features > > > > 6. Update Readme to add one section as > “How to build” > > > > > > BTW：Here is one important things about include third > party code: > > From its website > https://apache.org/legal/resolved.html > > CATEGORY X: WHAT CAN WE NOT INCLUDE IN AN ASF > PROJECT?¶ > > Apache project forbid some third party software > in it, it includes: > > 1. AGPL， LGPL，GPL > > 2. BSD + Fackbook patient > > 3.BSD-4-clouse > > > > > > > > > > 在 2019/3/19 下午3:04，“tan zhongyi”<[email protected]> > 写入: > > > > Here is one example from Doris's RD > > Doris just released its first apache version, > > The owner write a document step by step, very > details > > > > Here it is : > > > http://doris.apache.org/policy/release_process.html > > > > > > > > > > > > 在 2019/3/18 下午11:26，“tan zhongyi”< > [email protected]> 写入: > > > > Hi， guys, > > > > We need to release our first apache release > for brpc in Q2. > > > > And it will be a great step to be an TOP > level apache project for > > brpc. > > > > Here is some tasks that need to be done for > the release after I > > refer to document from apache.org > > > > > > 1. Get all dependency third party’s > copyright and apppend them > > to brpc License file > > > > 2. Add Notice and Disclaimer file to > mention its copyright > > belong to apache foundation > > > > 3. Make a short license header, and add > the header to all > > source files, including .h, .cpp, .java, etc > > > > 4. Check the source tarball to make sure > it does not contain > > binary files except for data > > > > 5. Prepare release note to list all > import checkin and features > > > > 6. Update Readme to add one section as > “How to build” > > > > > > > > > > When we finish these tasks, then we need to > open a thread to vote > > on [email protected]<mailto:[email protected]>, > > If got approved, we need to open another > vote on incubator mail > > list. > > If not approved, we should make changes > according to our mentor > > or other’s suggestion, and vote again. > > > > I remember that it is very common to have > several vote for the > > first release. > > > > That’s all for a release, anyone have > comments? > > Thanks > > > > > > > > > > > ?B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB�?�?[��X��ܚX�K??K[XZ[?�??]�][��X��ܚX�P?��?˘\?X�?K�ܙ�B��܈?Y??]?[ۘ[??��[X[�?�??K[XZ[?�??]�Z?[???��?˘\?X�?K�ܙ�B > > > ?B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB�?�?[��X��ܚX�K??K[XZ[ > �??]�][��X��ܚX�P?��?˘\?X�?K�ܙ�B��܈?Y??]?[ۘ[??��[X[�?�??K[XZ[ > �??]�Z?[???��?˘\?X�?K�ܙ�B > > > ?B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB�?�?[��X��ܚX�K??K[XZ[?�??]�][��X��ܚX�P?��?˘\?X�?K�ܙ�B��܈?Y??]?[ۘ[??��[X[�?�??K[XZ[?�??]�Z?[???��?˘\?X�?K�ܙ�B > > -- Jiashun Zhu
