zyearn commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351970084
##########
File path: src/brpc/redis.h
##########
@@ -124,7 +127,7 @@ class RedisRequest : public ::google::protobuf::Message {
void Print(std::ostream&) const;
protected:
- ::google::protobuf::Metadata GetMetadata() const override;
Review comment:
ci里开了-Winconsistent-missing-override，override要么全加要么全不加，这个之后再开个pr处理吧
https://travis-ci.org/apache/incubator-brpc/jobs/614981757?utm_medium=notification&utm_source=github_status
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
