zyearn commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r354729252
##########
File path: src/brpc/options.proto
##########
@@ -46,14 +46,14 @@ enum ProtocolType {
PROTOCOL_HTTP = 7;
PROTOCOL_PUBLIC_PBRPC = 8;
PROTOCOL_NOVA_PBRPC = 9;
- PROTOCOL_NSHEAD_CLIENT = 10; // implemented in baidu-rpc-ub
- PROTOCOL_NSHEAD = 11;
- PROTOCOL_HADOOP_RPC = 12;
- PROTOCOL_HADOOP_SERVER_RPC = 13;
- PROTOCOL_MONGO = 14; // server side only
- PROTOCOL_UBRPC_COMPACK = 15;
- PROTOCOL_DIDX_CLIENT = 16; // Client side only
- PROTOCOL_REDIS = 17; // Client side only
+ PROTOCOL_REDIS = 10;
+ PROTOCOL_NSHEAD_CLIENT = 11; // implemented in baidu-rpc-ub
+ PROTOCOL_NSHEAD = 12;
+ PROTOCOL_HADOOP_RPC = 13;
+ PROTOCOL_HADOOP_SERVER_RPC = 14;
+ PROTOCOL_MONGO = 15; // server side only
+ PROTOCOL_UBRPC_COMPACK = 16;
+ PROTOCOL_DIDX_CLIENT = 17; // Client side only
Review comment:
NSHEAD需要24个字符，而redis可能只有几个字符，如果在NSHEAD后面会解析不到redis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
