jamesge commented on a change in pull request #984:
fix_missing_brpc_version_in_release
URL: https://github.com/apache/incubator-brpc/pull/984#discussion_r354243423
##########
File path: CMakeLists.txt
##########
@@ -91,7 +91,7 @@ include_directories(
)
execute_process(
- COMMAND bash -c "git rev-parse --short HEAD | tr -d '\n'"
+ COMMAND bash -c "bash ${PROJECT_SOURCE_DIR}/tools/get_brpc_version.sh
${PROJECT_SOURCE_DIR} | tr -d '\n'"
Review comment:
里面还需要bash?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
