jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release URL: https://github.com/apache/incubator-brpc/pull/984#discussion_r354244557
########## File path: tools/get_brpc_version.sh ########## @@ -0,0 +1,10 @@ +#!/bin/bash + +output=$(cat $1/RELEASE_VERSION) +version=$(git log -1 --format="%h@%cI" 2> /dev/null) +branch=$(git rev-parse --abbrev-ref HEAD 2> /dev/null) +if [ $? -eq 0 ] +then + output=$output-$branch/$version Review comment: 如果output为空，以横线开头？ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
