jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r355398301
##########
File path: src/brpc/server.cpp
##########
@@ -1588,7 +1589,8 @@ void Server::GenerateVersionIfNeeded() {
if (!_version.empty()) {
return;
}
- int extra_count = !!_options.nshead_service + !!_options.rtmp_service +
!!_options.thrift_service;
+ int extra_count = !!_options.nshead_service + !!_options.rtmp_service +
+ !!_options.thrift_service + !!_options.redis_service;
Review comment:
nice-to-have: xxx_service为空时不加对应的handler。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
