jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r356953233
##########
File path: src/brpc/redis_reply.cpp
##########
@@ -189,7 +245,7 @@ ParseError RedisReply::ConsumePartialIOBuf(butil::IOBuf&
buf, butil::Arena* aren
return PARSE_ERROR_ABSOLUTELY_WRONG;
}
for (int64_t i = 0; i < count; ++i) {
- new (&subs[i]) RedisReply;
+ new (&subs[i]) RedisReply(NULL);
Review comment:
不是有没参数版本么？难道arena=null时和无参数构造行为不一致？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
