jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360760579
########## File path: src/butil/string_printf.h ########## @@ -45,6 +46,27 @@ int string_appendf(std::string* output, const char* format, ...) // Returns 0 on success, -1 otherwise. int string_vappendf(std::string* output, const char* format, va_list args); +// Format integer |d| to |output|, which is much faster than snprintf(..., "%lu", d); +// Return written length. Review comment: 改成这样后，我不清楚“much faster"是否还成立；强烈不建议把这么长的函数作为inlnie； ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
